Judging Competency - Does Summer Learn?

While working on some awful Javascript code this morning, I came across the following (in several places):

// make moveAmount negative
moveAmount = moveAmount - (moveAmount * 2);

I am sitting right across from the guy who wrote this; He has been a developer here for seven years. I, on the other hand, just started, I'm quite young and do not pretend to know that there is a jack.

However, it became interesting for me to learn about how the guy expels simple logic after so many years of software development.

My question is whether the opinions of others here can be accepted by the general competence of the developer who wrote this (3 weeks ago), or is this generally reflected?

Anyone mark a convolution?

I myself work in constant fear that such judgments are made of me.

+5
source share
9 answers

A simple solution: show him a line of code and ask why he did it. This is an opportunity for both of you to learn something. There might be a bug in the browser or some other problem (rounding comes to mind), so the code may break without it. Or he made a mistake. In any case, please clarify this.

And although you are right that other people will judge you from the code that they see from you, this is not the only thing they take into account (and if so, then you are working in the wrong place - leave while you are still healthy mind). They will also see when you are polite, curious, helpful.

These things count more than the code you write: code can be fixed much easier than angry employees.

+30
source

, ( , , , ). , , , : - , , ?

"". , , . . , . . ( .)

, , .

+4

, , ap ****, , , , :) , , 7 JavaScript, , - .

+3

. , - - , - . , , , - .

, - , , -, .

, , ; , , - .

+2

, , . , :

moveAmount = moveAmount * (-1)
+1

mountAmount = -moveAmount , 2 * moveAmount , moveAmount (, 2 ^ 32-1).

, .

+1

, , , . , . .

, , , , , . , , , .

... - ... , . , , , ?

+1

3 , , . , 7 .

:

moveAmount -= moveAmount * 2;

. , , , , .

, , , .

+1

, . , , , - , , . , . , , , , - .

, , . . , . , . , copy-paste... . , , .: -)

+1

All Articles