Geek Answers Handbook

Is this a bad design?

I try my best in behavior-based development, and I find myself second, guessing about my design when I write it. This is my first project, and it may just be a lack of experience. Anyway, here is a simple specification for the class (s) I am writing. This is written in NUnit in the style of BDD instead of using a special behavior-driven structure. This is because the project is targeting .NET 2.0 and all BDD environments seem to have embraced .NET 3.5.

[TestFixture]
public class WhenUserAddsAccount
{
    private DynamicMock _mockMainView;
    private IMainView _mainView;

    private DynamicMock _mockAccountService;
    private IAccountService _accountService;

    private DynamicMock _mockAccount;
    private IAccount _account;

    [SetUp]
    public void Setup()
    {
        _mockMainView = new DynamicMock(typeof(IMainView));
        _mainView = (IMainView) _mockMainView.MockInstance;

        _mockAccountService = new DynamicMock(typeof(IAccountService));
        _accountService = (IAccountService) _mockAccountService.MockInstance;

        _mockAccount = new DynamicMock(typeof(IAccount));
        _account = (IAccount)_mockAccount.MockInstance;
    }

    [Test]
    public void ShouldCreateNewAccount()
    {
        _mockAccountService.ExpectAndReturn("Create", _account);
        MainPresenter mainPresenter = new MainPresenter(_mainView, _accountService);
        mainPresenter.AddAccount();
        _mockAccountService.Verify();
    }
}

, MainPresenter, . AccountService . IAccount, . , , . AccountService .

, , - , /. BDD, ?

[]

MainPresenter.AddAccount

    public void AddAccount()
    {
        IAccount account;
        if (AccountService.AccountTypes.Count == 1)
        {
            account = AccountService.Create();
        }
        _view.Accounts.Add(account);
    }

, .

+5
7

" ", , . , , , . . BDD / unit test. unit test , , - ...

when_adding_an_account
   should_use_account_service_to_create_new_account
   should_update_screen_with_new_account_details

, IAccount. . .

...

  • , Mocking, ​​ Rhino Mocks ( Moq), .
  _mockAccountService.Expect(mock => mock.Create())
     .Return(_account);
  • BDD, , , . ...
public class MainPresenterSpec 
{
    // Protected variables for Mocks 

    [SetUp]
    public void Setup()
    {
       // Setup Mocks
    }

}

[TestFixture]
public class WhenUserAddsAccount : MainPresenterSpec
{
    [Test]
    public void ShouldCreateNewAccount()
    {
    }
}
  • , .
     public void AddAccount()
     {
        if (AccountService.AccountTypes.Count != 1)
        {
            // Do whatever you want here.  throw a message?
        return;
        }

    IAccount account = AccountService.Create();

        _view.Accounts.Add(account);
     }
+3

, , RhinoAutoMocker ( StructureMap). , (). 20 , , .

using StructureMap.AutoMocking;

namespace Foo.Business.UnitTests
{
    public class MainPresenterTests
    {
        public class When_asked_to_add_an_account
        {
            private IAccountService _accountService;
            private IAccount _account;
            private MainPresenter _mainPresenter;

            [SetUp]
            public void BeforeEachTest()
            {
                var mocker = new RhinoAutoMocker<MainPresenter>();
                _mainPresenter = mocker.ClassUnderTest;
                _accountService = mocker.Get<IAccountService>();
                _account = MockRepository.GenerateStub<IAccount>();
            }

            [TearDown]
            public void AfterEachTest()
            {
                _accountService.VerifyAllExpectations();
            }

            [Test]
            public void Should_use_the_AccountService_to_create_an_account()
            {
                _accountService.Expect(x => x.Create()).Return(_account);
                _mainPresenter.AddAccount();
            }
        }
    }
}

RunningThemAllTogether, . , , , . . NUnit , :

Foo.Business.UnitTests.MainPresenterTest
  When_asked_to_add_an_account
    Should_use_the_AccountService_to_create_an_account
    Should_add_the_Account_to_the_View
+2

, .

, unit test, , , , , .

+1

, . mocks:)

, , , , . , , - , .

- , , , .

, , ( ) . , , ..

+1

MockContainers, , . .

0

, - - IoC. (), , , , unit test ( , ), - mocks.

, , mainView, mockMainView, unit test - .

0

, , .

. A . B + A. , C C + B + A.

"_mockAccountService". AccountService , . , , MainPresentor, .

AccountService , . , , , . , , .

0

More articles:


All Articles