Effective use of Java Reflection - is it hacking or is this standard practice?

Question

Hi, listener for the first time for a long time, and I ask a question related to Java reflection, and how easily it lends itself to obviously ugly coding. The following method tries to take two similar objects (one object having all the fields of another object, and then some) and compare two of them for equality. It (presumably) will return true if the getters that share the objects are equal, and will return false if they are not equal.

public boolean validateArchive( Object record, Object arcRecord ) throws IllegalAccessException, InvocationTargetException, NoSuchMethodException
{
    log.debug( record.getClass().toString() );

    Object methodValue;
    Object arcMethodValue;

    for ( Method method : record.getClass().getMethods() )
    {
        if ( method.getTypeParameters().length == 0 && method.getName().startsWith( "get" ) && !method.getName().startsWith( "getClass" ) )
        {
            methodValue = method.invoke( record );
            arcMethodValue = arcRecord.getClass().getMethod( method.getName() ).invoke( arcRecord );

            log.debug( "Method name: " + method.getName() );
            log.debug( "Archive value: " + arcMethodValue );
            log.debug( "Object value: " + methodValue );

            if ( arcMethodValue != null && methodValue != null && !arcMethodValue.equals( methodValue ) )
            {
                return false;
            }
            else
            {
                if ( arcMethodValue == null && methodValue != null || methodValue == null && arcMethodValue != null )
                {
                    return false;
                }
            }
        }
    }

    return true;
}

, , ( "" ). , /. - , , ..

Answer 1

equals , , (, ). IDE, IntelliJ, "equals" "hashcode" ( IntelliJ , ). , .

, , Reflection - unit test, , , , " - " - , , , , .

PS: , Beans ; PS 2: , , - Spring , . .

Answer 2

"", commons beanutils ...

( , .equals, ...)

Answer 3

, if :

if ( arcMethodValue == null ) {
    if ( methodValue != null) {
        return false;
    }
} else if ( !arcMethodValue.equals( methodValue ) ) {
    return false;
}

, method.getName() 4 , , .

Answer 4

. :

  (field1 == null) ? (field2 == null) : field1.equals(field2);

(Effective Java 2nd Edition, . 43).

---

Update:

, return [idiom]. , return , . if ![idiom] return false;. , [idiom] , .