I recently solved one of my problems using a decorator pattern. Everything works fine, and everything is quite decoupled (or, I think) that I can unit test each valid field separately.
My question is if NameValidator and AgeValidator pass tests for Validate () and IsValid () (abstract) functions. Do I still need the unit test class ValidationDecorator (not yet created)? ValidationDecorator will be responsible for issuing my validator with each validation class.
public abstract class FieldValidator
{
protected IMessage validateReturnType;
public FieldValidator() { }
public bool IsValid()
{
return (validateReturnType.GetType() == typeof(Success));
}
}
public class NameValidator : FieldValidator, IValidator
{
private string name;
public NameValidator(string _name) {
name = _name;
}
public IMessage Validate()
{
if (name.Length < 5)
{
validateReturnType = new Error("Name error.");
}
else
{
validateReturnType = new Success("Name no errror.");
}
return validateReturnType;
}
}
public class AgeValidator : FieldValidator, IValidator
{
private int age;
public AgeValidator(int _age)
{
age = _age;
}
public IMessage Validate()
{
if (age <= 18)
{
validateReturnType = new Error("Age error.");
}
else
{
validateReturnType = new Success("Age no errror.");
}
return validateReturnType;
}
}
public interface IValidator
{
IMessage Validate();
bool IsValid();
}
This is my unit test.
[TestFixture]
public class ValidatorTest
{
Type successType;
Type errorType;
Model m;
[SetUp]
public void SetUp()
{
successType = typeof(Success);
errorType = typeof(Error);
m = new Model();
m.Name = "Mike Cameron";
m.Age = 19;
m.Height = 325;
Validator v = new Validator();
v.Validate(m);
}
[Test]
public void ValidateNameTest()
{
IValidator im = new NameValidator(m.Name);
IMessage returnObj = im.Validate();
Assert.AreEqual(successType, returnObj.GetType());
}
[Test]
public void IsValidNameTest()
{
IValidator im = new NameValidator(m.Name);
IMessage returnObj = im.Validate();
Assert.IsTrue(im.IsValid());
}
[Test]
public void ValidateAgeTest()
{
IValidator im = new AgeValidator(m.Age);
IMessage returnObj = im.Validate();
Assert.AreEqual(successType, returnObj.GetType(), "Must be over 18");
}
[Test]
public void IsValidAgeTest()
{
IValidator im = new AgeValidator(m.Age);
IMessage returnObj = im.Validate();
Assert.IsTrue(im.IsValid());
}
Thank.
source
share