C free char * allocated per heap

Question

Is there a memory leak in the following code example since I allocated memory on the heap for a name that was not freed? If I add a free name (person-> name); in front of the free (person); line, then I get a runtime error in VS. "CRT found that the application was written to memory after the end of the heap buffer."

header.h:

#ifndef HEADER
#define HEADER

typedef struct person {
 char *name;
} Person;

#endif

source.c:

#include <stdio.h>
#include <stdlib.h>
#include "header.h"

#define BUFFERSIZE 500

int main (int argc, char* argv[]){
 Person *person = NULL;
 char buffer[BUFFERSIZE];
 printf("Enter name\n");
 fgets(buffer, BUFFERSIZE, stdin);
 {
  char *name; 
  person = malloc(sizeof(Person));
  name = malloc(strlen(buffer));
  strcpy (name,buffer);
  person->name = name;
 }
 free(person); 
 return 0;
}

Thanks Rob

Answer 1

Yes, the code has a memory leak.

Challenger: name = malloc(strlen(buffer));which should be name = malloc(strlen(buffer)+1);for accounting \0.

Now you can free person->name.

Answer 2

strlen -, strcpy, "malloc (strlen (buffer) +1)"

Answer 3

. .

:

name = malloc(strlen(buffer));

. , Person,

free(person); 

, .

, , , , , , .

Answer 4

name , .

, , ++ ( ) create/destroy/manipulation:

Person *CreatePerson(void) {
    /* you can use calloc() here, of course */
    Person *result = malloc(sizeof(Person));
    if (result) {
        memset(result, 0, sizeof(Person));
    }
    return result;
}

void DestroyPerson(Person *p) {
    if (p) {
        free(p->name);
        free(p);
    }
}

void SetPersonName(Person *p, const char *name) {
    if (p) {
        if (p->name) {
            free(p->name);
            p->name = NULL;
        }

        if (name) {
            size_t len = strlen(name);
            p->name = malloc(len + 1);
            if (p->name) {
                strncpy(p->name, name, len);
                p->name[len] = 0;
            }
        }
    }
}

const char *GetPersonName(const Person *p) {
    if (p)
        return p->name;
    return NULL;
}

, , ++ :

class Person {
    private: std::string name;

    public: const std::string& getName(void) const {
        return this->name;
    }

    public: void setName(const std::string& newName) {
        this->name = newName;
    }
};

, !