Geek Answers Handbook

Out of memory with multiple images in one window

I am running out of memory when I try to upload multiple images to a single file.

public void button2_Click(object sender, EventArgs e)
    {


        FolderBrowserDialog dialog = new FolderBrowserDialog();
        dialog.ShowDialog();
        string selected = dialog.SelectedPath;

        string[] imageFileList = Directory.GetFiles(selected);


        int iCtr = 0,zCtr = 0;
        foreach(string imageFile in imageFileList)
        {

            if (Image.FromFile(imageFile) != null)
            {
                Image.FromFile(imageFile).Dispose();
            }

            PictureBox eachPictureBox = new PictureBox();

            eachPictureBox.Size = new Size(100,100);
           // if (iCtr % 8 == 0)
            //{
             //   zCtr++;
              //  iCtr = 0;
            //}
            eachPictureBox.Location = new Point(iCtr * 100 + 1, 1);
            eachPictureBox.Image = Image.FromFile(imageFile);
            iCtr++;

            panel1.Controls.Add(eachPictureBox);

        }


    }`enter code here`
+1
source share
3 answers
if (Image.FromFile(imageFile) != null)
{
    Image.FromFile(imageFile).Dispose();
}

Bad You load the image from the file, checking if the result is zero ... then load it again into the new result so that you can destroy it. Although the last part is stupid, it is not harmful. The first part, however, since the resulting one is Imagenever deleted properly (if / when the GC collects it, the type finalizer Imageshould manage unmanaged resources, but this is not wise to rely on).

, Image.FromFile null. , OutOfMemoryException.

, if else .

, OutOfMemoryException , , .

foreach :

try
{
    Image image = Image.FromFile(imageFile);

    PictureBox eachPictureBox = new PictureBox();

    eachPictureBox.Size = new Size(100,100);

    eachPictureBox.Location = new Point(iCtr * 100 + 1, 1);
    eachPictureBox.Image = Image.FromFile(imageFile);
    iCtr++;

    panel1.Controls.Add(eachPictureBox);
}
catch(OutOfMemoryException) { } // skip the file
+1

, . , , .

+1

-, , , , , 4 .

, , . 70 , .

, , 70 JPEG 32- 1920x1080 . :

 70 pics x 1920 pixels x 1080 pixels x 4 bytes/pixel = 580,608,000 bytes!

.

.

0

More articles:


All Articles