AssertRises Failure

I am trying to write a unit test that will provide when an HTTPException is raised when necessary. Here is the test:

import unittest  
from requests import HTTPError
import pyport

 # Code omitted...
 def test_bad_item_type(self):
     """A bad item type should raise a HTTPError"""
     test_type = 'bad'
     test_id = 1986134
     self.assertRaises(HTTPError, pyport.get_item(test_type, test_id))

Which gives the following:

ERROR: test_bad_item_type (__main__.TestPyportFunctions) A bad item
type should raise requests.HTTPError
---------------------------------------------------------------------- 
Traceback (most   recent call last):   File "./tests.py", line 65, in
test_bad_item_type
    self.assertRaises(HTTPError, pyport.get_item(test_type, test_id))   File    "/home/sean/workspace/pyport/pyport.py", line 54, in get_item
    response.raise_for_status()   File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 741, fin raise_for_status
    raise HTTPError('%s Client Error' % self.status_code) HTTPError: 404 Client Error

The exception is increased, but the test fails. This is similar to what happened in this question , but it is not quite the same. Can someone tell me what I am missing?

+5
source share
2 answers

It should be:

self.assertRaises(HTTPError, pyport.get_item, test_type, test_id)

See signature assertRaises:

assertRaises(exception, callable, *args, **kwds)

, -, Python first pyport.get_item(test_type, test_id), assertRaises. assertRaises , . , assertRaises , .

+7

Python 2.7 , unittest2 backported unittest, assertRaises, :

with self.assertRaises(HTTPError):
    pyport.get_item(test_type, test_id)

http://docs.python.org/library/unittest.html#basic-example

+1

All Articles