Mongoose.pre ('save') not starting

Question

I have the following model for mongoose.model('quotes') :

 var mongoose = require('mongoose'); var Schema = mongoose.Schema; var quotesSchema = new Schema({ created: { type: String, default: moment().format() }, type: { type: Number, default: 0 }, number: { type: Number, required: true }, title: { type: String, required: true, trim: true}, background: { type: String, required: true }, points: { type: Number, default: 1 }, status: { type: Number, default: 0 }, owner: { type: String, default: "anon" } }); var settingsSchema = new Schema({ nextQuoteNumber: { type: Number, default: 1 } }); // Save Setting Model earlier to use it below mongoose.model('settings', settingsSchema); var Setting = mongoose.model('settings'); quotesSchema.pre('save', true, function(next) { Setting.findByIdAndUpdate(currentSettingsId, { $inc: { nextQuoteNumber: 1 } }, function (err, settings) { if (err) { console.log(err) }; this.number = settings.nextQuoteNumber - 1; // substract 1 because I need the 'current' sequence number, not the next next(); }); }); mongoose.model('quotes', quotesSchema); 

There is an additional scheme for mongoose.model('settings') to store the incremental number for the incremental unique Quote.number im index trying to set. Before each save, quotesSchema.pre('save') is called to read, increment, and pass nextQuoteNumber as this.number to the next() function.

However, all this .pre('save') function does not seem to work when saving Quote elsewhere. Mongoose cancels the save, since number is required but not defined, and no console.log() I write to a function ever prints anything.

Answer 1

Use pre('validate') instead of pre('save') to set the value for the required field. Mongoose validates documents before saving, so your save middleware will not be called if there are validation errors. Switching the middleware from save to validate will cause your function to set the number field before checking it.

 quotesSchema.pre('validate', true, function(next) { Setting.findByIdAndUpdate(currentSettingsId, { $inc: { nextQuoteNumber: 1 } }, function (err, settings) { if (err) { console.log(err) }; this.number = settings.nextQuoteNumber - 1; // substract 1 because I need the 'current' sequence number, not the next next(); }); });