Return value for exception

Question

Why is this code not compiling?
This gives me an error:

not all code paths return a value

Code:

public bool isUserProfileHashed(string username) { bool isHashed = false; MembershipUser u = null; u = Membership.GetUser(username); if (u != null) { try { u.GetPassword(); } catch (Exception exception) { // An exception is thrown when the GetPassword method is called for a user with a hashed password isHashed = true; return isHashed; } return isHashed; } 

Answer 1

You forgot to put return out from if, put it after the end is over

 public bool isUserProfileHashed(string username) { bool isHashed = false; MembershipUser u = null; u = Membership.GetUser(username); if (u != null) { try { u.GetPassword(); } catch { // An exception is thrown when the GetPassword method is called for a user with a hashed password isHashed = true; } } return isHashed; } 

[change]
Delete Unnecessary Return (@Fredrik Mörk)
A fixed exception that was not used also deleted it.

Answer 2

There is no return statement outside the if block. Sometimes, if the block may not execute.

Answer 3

No return if u is null.

Answer 4

If u == null, your entire if statement will be passed through . Outside the if statement, there is no return statement.

That's why you see: not all code paths return a value .

Just add a return statement after the if block:

 public bool isUserProfileHashed(string username) { bool isHashed = false; MembershipUser u = null; u = Membership.GetUser(username); if (u != null) { // ... return isHashed; } // more code here if you need it return ??? ; // <--- **ADD THIS** } 

Answer 5

You do not handle the case where u == null and return a value if this condition is met.

Answer 6

If u turns out to be null , you will not return!

This should work better.

 public bool isUserProfileHashed(string username) { bool isHashed = false; MembershipUser u = null; u = Membership.GetUser(username); if (u != null) { try { u.GetPassword(); } catch (Exception exception) { // An exception is thrown when the GetPassword method is called for a user with a hashed password isHashed = true; return isHashed; } return isHashed; } else { //Throw or return false, whatever throw new Exception("Could not get user ..."); } } 

Answer 7

The amendment to your method was marked by other posters, however, is it possible to replace the whole method with this line?

 if(Membership.Provider.PasswordFormat == MembershipPasswordFormat.Hashed)