Attempted to read or write protected memory

I have a problem with the MAPI class below (source source http://www.codeproject.com/KB/IP/SendFileToNET.aspx )

When users try to send emails using the SendMailPopup method, the email program opens correctly, but after closing the mail window the program sometimes discards the message: Attempted to read or write protected memory. This is often an indication that other memory is corrupt. Attempted to read or write protected memory. This is often an indication that other memory is corrupt.

I suspect that the error was caused by the cleanup method, and I was able to reduce the frequency of failures by using Int64 to store pointers instead of ints used in the original version. However, I do not know how to program, but I do not know how to do it. Someone can help me find out what causes the rest of the crashes.

Update. Apparently, the cleanup method throws no exceptions, since the program crashes even when it is commented out, so the only possible reason is the sendmail method MAPI32.ddl. Perhaps something is wrong with the pointers passed to it as parameters.

Users use systems with 64-bit processors and 32-bit winxp.

Update:

The solutions provided in this thread reduced the frequency of failures, but did not completely solve the problem. The only solution that worked 100% was to create a small console application using C ++ that actually made MAPI calls. Our .NET application interacts with mapi, launching a console application and passing data to it using arguments.

  public class MAPI { public bool AddRecipientTo(string email) { return AddRecipient(email, HowTo.MAPI_TO); } public bool AddRecipientCC(string email) { return AddRecipient(email, HowTo.MAPI_CC); } public bool AddRecipientBCC(string email) { return AddRecipient(email, HowTo.MAPI_BCC); } public void AddAttachment(string strAttachmentFileName) { m_attachments.Add(strAttachmentFileName); } public int SendMailPopup(string strSubject, string strBody) { return SendMail(strSubject, strBody, MAPI_LOGON_UI | MAPI_DIALOG); } public int SendMailDirect(string strSubject, string strBody) { return SendMail(strSubject, strBody, MAPI_LOGON_UI); } [DllImport("MAPI32.DLL")] static extern int MAPISendMail(IntPtr sess, IntPtr hwnd, MapiMessage message, int flg, int rsv); int SendMail(string strSubject, string strBody, int how) { MapiMessage msg = new MapiMessage(); msg.subject = strSubject; msg.noteText = strBody; msg.recips = GetRecipients(out msg.recipCount); msg.files = GetAttachments(out msg.fileCount); m_lastError = MAPISendMail(new IntPtr(0L), new IntPtr(0L), msg, how, 0); if (m_lastError > 1) MessageBox.Show("MAPISendMail failed! " + GetLastError(), "MAPISendMail"); Cleanup(ref msg); return m_lastError; } bool AddRecipient(string email, HowTo howTo) { if (!String.IsNullOrEmpty(email)) { MapiRecipDesc recipient = new MapiRecipDesc(); recipient.recipClass = (int)howTo; recipient.name = email; m_recipients.Add(recipient); return true; } else { return false; } } IntPtr GetRecipients(out int recipCount) { recipCount = 0; if (m_recipients.Count == 0) return IntPtr.Zero; int size = Marshal.SizeOf(typeof(MapiRecipDesc)); IntPtr intPtr = Marshal.AllocHGlobal(m_recipients.Count * size); int ptr = (int)intPtr; foreach (MapiRecipDesc mapiDesc in m_recipients) { Marshal.StructureToPtr(mapiDesc, (IntPtr)ptr, false); ptr += size; } recipCount = m_recipients.Count; return intPtr; } IntPtr GetAttachments(out int fileCount) { fileCount = 0; if (m_attachments == null) return IntPtr.Zero; if ((m_attachments.Count <= 0) || (m_attachments.Count > maxAttachments)) return IntPtr.Zero; int size = Marshal.SizeOf(typeof(MapiFileDesc)); IntPtr intPtr = Marshal.AllocHGlobal(m_attachments.Count * size); MapiFileDesc mapiFileDesc = new MapiFileDesc(); mapiFileDesc.position = -1; int ptr = (int)intPtr; foreach (string strAttachment in m_attachments) { mapiFileDesc.name = Path.GetFileName(strAttachment); mapiFileDesc.path = strAttachment; Marshal.StructureToPtr(mapiFileDesc, (IntPtr)ptr, false); ptr += size; } fileCount = m_attachments.Count; return intPtr; } void Cleanup(ref MapiMessage msg) { try { int size = Marshal.SizeOf(typeof(MapiRecipDesc)); Int64 ptr = 0; if (msg.recips != IntPtr.Zero) { ptr = msg.recips.ToInt64(); for (int i = 0; i < msg.recipCount; i++) { Marshal.DestroyStructure((IntPtr)ptr, typeof(MapiRecipDesc)); ptr += size; } Marshal.FreeHGlobal(msg.recips); } if (msg.files != IntPtr.Zero) { size = Marshal.SizeOf(typeof(MapiFileDesc)); ptr = msg.files.ToInt64(); for (int i = 0; i < msg.fileCount; i++) { Marshal.DestroyStructure((IntPtr)ptr, typeof(MapiFileDesc)); ptr += size; } Marshal.FreeHGlobal(msg.files); } m_recipients.Clear(); m_attachments.Clear(); } catch (Exception e) { SmtpSender errorSender = new SmtpSender(); errorSender.SendAutomaticError(e.StackTrace + e.Message, "Virhe mapi sähköpostin lähetyksessä" + MySession.ProjectName + " Käyttäjä:" + MySession.LoginName); } } public string GetLastError() { if (m_lastError <= 26) return errors[m_lastError]; return "MAPI error [" + m_lastError.ToString() + "]"; } readonly string[] errors = new string[] { "OK [0]", "User abort [1]", "Yleinen virhe sähköpostin lähettämisessä [2]", "MAPI login failure [3]", "Disk full [4]", "Insufficient memory [5]", "Access denied [6]", "-unknown- [7]", "Too many sessions [8]", "Too many files were specified [9]", "Too many recipients were specified [10]", "A specified attachment was not found [11]", "Attachment open failure [12]", "Attachment write failure [13]", "Unknown recipient [14]", "Bad recipient type [15]", "No messages [16]", "Invalid message [17]", "Text too large [18]", "Invalid session [19]", "Type not supported [20]", "A recipient was specified ambiguously [21]", "Message in use [22]", "Network failure [23]", "Invalid edit fields [24]", "Asiakkaalle ei ole määritetty sähköpostiosoitetta.", "Not supported [26]" }; List<MapiRecipDesc> m_recipients = new List<MapiRecipDesc>(); List<string> m_attachments = new List<string>(); int m_lastError = 0; const int MAPI_LOGON_UI = 0x00000001; const int MAPI_DIALOG = 0x00000008; const int maxAttachments = 20; enum HowTo { MAPI_ORIG = 0, MAPI_TO, MAPI_CC, MAPI_BCC }; } [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Ansi)] public class MapiMessage { public int reserved; public string subject; public string noteText; public string messageType; public string dateReceived; public string conversationID; public int flags; public IntPtr originator; public int recipCount; public IntPtr recips; public int fileCount; public IntPtr files; } [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Ansi)] public class MapiFileDesc { public int reserved; public int flags; public int position; public string path; public string name; public IntPtr type; } [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Ansi)] public class MapiRecipDesc { public int reserved; public int recipClass; public string name; public string address; public int eIDSize; public IntPtr entryID; } 

The following is the meaning of stacktrace exceptions. This is partly in Finnish, but you can still see the method names from it.

kohteessa System.Windows.Forms.UnsafeNativeMethods.DispatchMessageA(MSG& msg) kohteessa System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData) kohteessa System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context) kohteessa System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context) kohteessa System.Windows.Forms.Application.Run(Form mainForm)

+4
source share
2 answers

You have not used Int64 sequentially (GetRecipients and GetAttachments). I suspect that this is a problem, but I did not dwell on this in detail. Below are the necessary changes. Note that I used a slightly different IntPtr increment method, which is slightly less error prone.

Modified to use Jörg's suggestion to increase the buffer size of the file attachment path.

 public class MAPI { public bool AddRecipientTo(string email) { return AddRecipient(email, HowTo.MAPI_TO); } public bool AddRecipientCC(string email) { return AddRecipient(email, HowTo.MAPI_CC); } public bool AddRecipientBCC(string email) { return AddRecipient(email, HowTo.MAPI_BCC); } public void AddAttachment(string strAttachmentFileName) { m_attachments.Add(strAttachmentFileName); } public int SendMailPopup(string strSubject, string strBody) { return SendMail(strSubject, strBody, MAPI_LOGON_UI | MAPI_DIALOG); } public int SendMailDirect(string strSubject, string strBody) { return SendMail(strSubject, strBody, MAPI_LOGON_UI); } int SendMail(string strSubject, string strBody, int how) { MapiMessage msg = new MapiMessage(); msg.subject = strSubject; msg.noteText = strBody; msg.recips = GetRecipients(out msg.recipCount); msg.files = GetAttachments(out msg.fileCount); m_lastError = MAPISendMail(new IntPtr(0L), new IntPtr(0L), msg, how, 0); if (m_lastError > 1) MessageBox.Show("MAPISendMail failed! " + GetLastError(), "MAPISendMail"); Cleanup(ref msg); return m_lastError; } bool AddRecipient(string email, HowTo howTo) { if (!String.IsNullOrEmpty(email)) { MapiRecipDesc recipient = new MapiRecipDesc(); recipient.recipClass = (int)howTo; recipient.name = email; m_recipients.Add(recipient); return true; } else { return false; } } IntPtr GetRecipients(out int recipCount) { recipCount = 0; if (m_recipients.Count == 0) return IntPtr.Zero; int size = Marshal.SizeOf(typeof(MapiRecipDesc)); IntPtr blockPtr = Marshal.AllocHGlobal(m_recipients.Count * size); IntPtr currentPtr = blockPtr; foreach (MapiRecipDesc mapiDesc in m_recipients) { Marshal.StructureToPtr(mapiDesc, currentPtr, false); currentPtr = (IntPtr)((long)currentPtr + size); } recipCount = m_recipients.Count; return blockPtr; } IntPtr GetAttachments(out int fileCount) { fileCount = 0; if (m_attachments == null) return IntPtr.Zero; if ((m_attachments.Count <= 0) || (m_attachments.Count > maxAttachments)) return IntPtr.Zero; int size = Marshal.SizeOf(typeof(MapiFileDesc)); IntPtr blockPtr = Marshal.AllocHGlobal(m_attachments.Count * size); IntPtr currentPtr = blockPtr; MapiFileDesc mapiFileDesc = new MapiFileDesc(); mapiFileDesc.position = -1; foreach (string strAttachment in m_attachments) { mapiFileDesc.name = Path.GetFileName(strAttachment); mapiFileDesc.path = Marshal.AllocHGlobal(MAX_PATH); CopyStringAnsi(mapiFileDesc.path, strAttachment); Marshal.StructureToPtr(mapiFileDesc, currentPtr, false); currentPtr = (IntPtr)((long)currentPtr + size); } fileCount = m_attachments.Count; return blockPtr; } void Cleanup(ref MapiMessage msg) { try { if (msg.recips != IntPtr.Zero) { IntPtr currentPtr = msg.recips; int size = Marshal.SizeOf(typeof(MapiRecipDesc)); for (int i = 0; i < msg.recipCount; i++) { Marshal.DestroyStructure(currentPtr, typeof(MapiRecipDesc)); currentPtr = (IntPtr)((long)currentPtr + size); } Marshal.FreeHGlobal(msg.recips); } if (msg.files != IntPtr.Zero) { IntPtr currentPtr = msg.files; int size = Marshal.SizeOf(typeof(MapiFileDesc)); for (int i = 0; i < msg.fileCount; i++) { Marshal.DestroyStructure(currentPtr, typeof(MapiFileDesc)); currentPtr = (IntPtr)((long)currentPtr + size); } Marshal.FreeHGlobal(msg.files); } m_recipients.Clear(); m_attachments.Clear(); } catch (Exception e) { SmtpSender errorSender = new SmtpSender(); errorSender.SendAutomaticError(e.StackTrace + e.Message, "Virhe mapi sähköpostin lähetyksessä" + MySession.ProjectName + " Käyttäjä:" + MySession.LoginName); } } public string GetLastError() { if (m_lastError <= 26) return errors[m_lastError]; return "MAPI error [" + m_lastError.ToString() + "]"; } readonly string[] errors = new string[] { "OK [0]", "User abort [1]", "Yleinen virhe sähköpostin lähettämisessä [2]", "MAPI login failure [3]", "Disk full [4]", "Insufficient memory [5]", "Access denied [6]", "-unknown- [7]", "Too many sessions [8]", "Too many files were specified [9]", "Too many recipients were specified [10]", "A specified attachment was not found [11]", "Attachment open failure [12]", "Attachment write failure [13]", "Unknown recipient [14]", "Bad recipient type [15]", "No messages [16]", "Invalid message [17]", "Text too large [18]", "Invalid session [19]", "Type not supported [20]", "A recipient was specified ambiguously [21]", "Message in use [22]", "Network failure [23]", "Invalid edit fields [24]", "Asiakkaalle ei ole määritetty sähköpostiosoitetta.", "Not supported [26]" }; List<MapiRecipDesc> m_recipients = new List<MapiRecipDesc>(); List<string> m_attachments = new List<string>(); int m_lastError = 0; const int MAPI_LOGON_UI = 0x00000001; const int MAPI_DIALOG = 0x00000008; const int maxAttachments = 20; const int MAX_PATH = 256; enum HowTo { MAPI_ORIG = 0, MAPI_TO, MAPI_CC, MAPI_BCC }; [DllImport("MAPI32.DLL")] static extern int MAPISendMail(IntPtr sess, IntPtr hwnd, MapiMessage message, int flg, int rsv); [DllImport("kernel32.dll", EntryPoint = "RtlMoveMemory", CharSet = CharSet.Ansi)] static extern void RtlMoveStringAnsi(IntPtr pdst, string psrc, IntPtr sizetcb); private void CopyStringAnsi(IntPtr intPtr, string str) { int length = (str.Length + 1) * Marshal.SystemMaxDBCSCharSize; RtlMoveStringAnsi(intPtr, str, (IntPtr)length); } [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Ansi)] class MapiMessage { public int reserved; public string subject; public string noteText; public string messageType; public string dateReceived; public string conversationID; public int flags; public IntPtr originator; public int recipCount; public IntPtr recips; public int fileCount; public IntPtr files; } [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Ansi)] class MapiFileDesc { public int reserved; public int flags; public int position; public IntPtr path; public string name; public IntPtr type; } [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Ansi)] class MapiRecipDesc { public int reserved; public int recipClass; public string name; public string address; public int eIDSize; public IntPtr entryID; } } 
+2
source

I noticed that a call to the MAPISendMail buffer (s) containing the full file name of the attachment (s) in msg.files will be overwritten by the mapi service provider (?). Providing a longer buffer fixed these problems.

-1
source

All Articles