How can I make this code easier?

if(condition 1){ var=changeVar(var); changed=true; } if(condition 2){ var=changeVar2(var); changed=true; } if(condition 3){ var=changeVar3(var); changed=true; } 

I do not like how changed=true; repeated three times.

+4
source share
5 answers

Can I save the old var and compare it?

 oldVar = var; //your code here. changed = (oldVar != var); 

At the beginning I had == , but could it not give the wrong (or at least different) solution then in the question?

+7
source
 <?php if (condition 1) { var=changeVar(var); } if (condition 2) { var=changeVar2(var); } if (condition 3) { var=changeVar3(var); } changed=(condition 1||condition 2||condition 3||changed); // set changed value only if condition 1, condition 2 or condition 3 is true, keep old value otherwise ?> 
+2
source
 if (condition 1 || condition 2 || condition 3) { if (condition 1) { var = changeVar(var); } if (condition 2) { var = changeVar2(var); } if (condition 3) { var = changeVar3(var); } changed = true; } 
+1
source
 $changed = true; if ($cond1) {} elseif ($cond2) {} else { $changed = false; } 
+1
source
 if(condition1||condition2||condition3) { switch(condition) { case 1: var = changeVar(var); break; case 2: var = changeVar2(var); break; case 3: var = changeVar3(var); break; } changed = true; } 
-1
source

All Articles