Avoiding Duplication of PendingIntents

Question

Hello!

I have a problem with duplicate PendingIntents. My application has a service that runs in the onCreate application, performs some Async task, and stops on its own. The problem is that every time I start the application, I have a new set of PendingIntents from DB (exactly the same) in AlarmManager, but they will not cancel the previous one, even with FLAG_CANCEL_CURRENT. I define this with the "adb shell dumpsys alarm",
Here is the onPostExecute Async task: protected void onPostExecute (cursor c) {

while (c.moveToNext()) { int _id = c.getInt(c.getColumnIndex(Maindb._ID)); long remind_timestamp = c.getLong(c .getColumnIndex(Maindb.REMIND_TIMESTAMP)); String remind_name = c.getString(c.getColumnIndex(Maindb.NAME)); String remind_description = c.getString(c .getColumnIndex(Maindb.DESCRIPTION)); Log.i("Service reminders : id = " + _id + "; REMIND_TIMESTAMP=" + remind_timestamp + "; NAME = " + remind_name + "; DESCRIPTION=" + remind_description); Intent myIntent = new Intent(ReminderService.this, AlarmReceiver.class); myIntent.putExtra(RemindDialog.REMIND_DIALOG_ID, _id); myIntent.putExtra(RemindDialog.REMIND_DIALOG_NAME, remind_name); myIntent.putExtra(RemindDialog.REMIND_DIALOG_DESCRIPTION, remind_description); myIntent.putExtra(RemindDialog.REMIND_DIALOG_TIMESTAMP, remind_timestamp); pendingIntent = PendingIntent.getService(ReminderService.this, _id, myIntent, PendingIntent.FLAG_CANCEL_CURRENT | PendingIntent.FLAG_ONE_SHOT); AlarmManager alarmManager = (AlarmManager) getSystemService(ALARM_SERVICE); alarmManager.set(AlarmManager.RTC_WAKEUP, remind_timestamp, pendingIntent); Log.i("Successfully setted alarm for ID:TIMESTAMP = " + _id + ":" + remind_timestamp); } Log.d("Closing cursor"); c.close(); Log.d("Nothing else to do, Stoping the services by himself"); stopSelf(); } 

The output from the "adb shell dumpsys alarm message" after the second application launch is as follows:

RTC_WAKEUP # 26: Alarm {42096e70 type 0 com} type = 0 when = + 93d9h0m54s107ms repeatInterval = 0 count = 0 operation = PendingIntent {4283e8b8: PendingIntentRecord {426ab530 com.startService}}

RTC_WAKEUP # 25: Alarm {41dff7f8 type 0 com.} Type = 0 when = + 93d9h0m54s107ms repeatInterval = 0 count = 0 operation = PendingIntent {41f1e730: PendingIntentRecord {41e7e1b0 com.startService}}

RTC_WAKEUP # 24: Alarm {42161b60 type 0 com} type = 0 when = + 76d19h50m54s107ms repeatInterval = 0 count = 0 operation = PendingIntent {428494d8: PendingIntentRecord {42705b90 com.startService}}

RTC_WAKEUP # 23: Alarm {41ef50a8 type 0 com} type = 0 when = + 76d19h50m54s107ms repeatInterval = 0 count = 0 operation = PendingIntent {41f1de18: PendingIntentRecord {41efdcd0 com.startService}}

RTC_WAKEUP # 22: Alarm {42549b40 type 0 com} type = 0 when = + 51d5h30m54s107ms repeatInterval = 0 count = 0 operation = PendingIntent {428697e8: PendingIntentRecord {427c9890 com.startService}}

RTC_WAKEUP # 21: Alarm {41f2fe20 type 0 com.} Type = 0 when = + 51d5h30m54s107ms repeatInterval = 0 count = 0 operation = PendingIntent {41fb31a0: PendingIntentRecord {41f3d018 com.startService}}

RTC_WAKEUP # 20: Alarm {4269f008 type 0 com.} Type = 0 when = + 21d10h30m54s107ms repeatInterval = 0 count = 0 operation = PendingIntent {428706f0: PendingIntentRecord {427fd1f0 com.startService}}

RTC_WAKEUP # 19: Alarm {41fb1428 type 0 com} type = 0 when = + 21d10h30m54s107ms repeatInterval = 0 count = 0 operation = PendingIntent {41f3c958: PendingIntentRecord {4212d098 com.startService}}

RTC_WAKEUP # 18: Alarm {426aa948 type 0 com} type = 0 when = + 16d14h16m54s107ms repeatInterval = 0 count = 0 operation = PendingIntent {42875fb8: PendingIntentRecord {4282bf98 com.startService}}

RTC_WAKEUP # 17: Alarm {42554a70 type 0 com} type = 0 when = + 16d14h16m54s107ms repeatInterval = 0 count = 0 operation = PendingIntent {41ec39e8: PendingIntentRecord {426a0620 com.startService}}

So, the main question is why my PendingIntents are duplicating, because at first glance, the first and second launch should do exactly the same thing (the input cursor is definitely the same).

Thanks! Sorry for my English.

Answer 1

You may have replaced PendingIntent so that you don't have duplicates. However, you did not cancel the previously set alarm using AlarmManager . To do this, you need to call:

 alarmManager.cancel(pendingIntent); 

before execution:

 alarmManager.set(AlarmManager.RTC_WAKEUP, remind_timestamp, pendingIntent); 

This will cancel any alarms that match the PendingIntent passed. Strike>

EDIT: the above answer did not help the OP and is probably wrong (see comment from AC)

When replacing PendingIntent you need to use PendingIntent.FLAG_UPDATE_CURRENT instead of PendingIntent.FLAG_CANCEL_CURRENT . This should only result in 1 scheduled alarm.

The problem is that by canceling the existing PendingIntent when creating a new one, you will make it impossible for the AlarmManager determine that the alarm you are planning replaces another (since it cannot compare the PendingIntent because the old one is gone).