Geek Answers Handbook

Contributing to an existing pull request

I have a repository and someone sent a transfer request. I want to make some changes to this retrieval request before making it, is it possible to do this?

Notice, I expect my commits to appear in the request request stream, so that the conversation continues, etc.

I know that I can leave, clone his fork and retract my branch as soon as I finish, but this is not very suitable for the workflow around discussion and improvement.

+4
source share
3 answers

If your repository has an open transfer request, only if you commit the repository and the branch (their repository and their branch) that will have an open pull request will work.

So, you need to create a request to transfer to the forker repository if you want to get literally what you requested - so that your commits appear in their pull request

+5
source

GitHub added the ability to allow users with write permissions to the branch against which the PR is raised in order to have write permissions to the original branch.

This is a failure function, i.e.

Request creators can only provide support to third-party repositories with pulling, or those who have push access to the upstream repository are allowed to commit in the request request comparison branch.

[..]

Request request creators can provide these permissions for each of their pull requests when they initially create a pull request or after they create a pull request.

https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

Example

Lets use this PR as an example, https://github.com/gajus/table/pull/19 .

Epoberezkin created a migration request for gajus:master . The origin of this request is epoberezkin:precompile-schemas . Therefore, as a user with write permissions on gajus:master , I can click on the epoberezkin:precompile-schemas , and these changes will be reflected in PR, i.e.

 git clone git@github.com :gajus/table.git cd table git remote add epoberezkin git@github.com :epoberezkin/table.git git fetch epoberezkin git checkout epoberezkin/precompile-schemas # Make changes, commit changes. git push epoberezkin HEAD:precompile-schemas
+2
source

You just need

  • download branch
  • make changes
  • pass them
  • click on them

After clicking the changes, you will see them in the request to submit Github and the workflow will be followed.

+1
source

More articles:


All Articles