Wrapper for ajax jQuery function. Callback activated but no parameters

I am very new to JavaScript, so the question may be fictitious. I make a lot of GET and POST requests in my code, so I decided to write a wrapper function to call the jQuery ajax function

/**
 * Makes Get request
 * @param url URL
 * @param successCallback function triggered when request is successfully proceeded
 * @param failCallback  function triggered is case of failed request
 */
function getRequest(url,successCallback,failCallback){
    $.ajax({
        url: url,
        timeout: 3000,
        dataType: "json",
        success: function(data,textStatus,jqXHR){
            successCallback(data,textStatus,jqXHR);
        },
        error: failCallback(jqXHR,textStatus,errorThrown)
    });
}

I call it this way:

url = "/api/info";
function onSuccess(data,textStatus,jqXHR){
        $("#result").html("Hostname is "+data.hostname);
}
function onFail(jqXHR,textStatus,errorThrown){
        $("#result").html("Shit happens");
}
//fire request
getRequest(url,onSuccess(),onFail());

The callback starts, but the data is undefined.

+4
source share
1 answer

Finally, I fixed it with the rewrite function as follows:

function getRequest(url,successCallback,failCallback){
    $.ajax({
        url: url,
        timeout: 3000,
        dataType: "json",
        success: function(data,textStatus,jqXHR){
            successCallback(data,textStatus,jqXHR);
        },
        error: function(jqXHR,textStatus,errorThrown){
            failCallback(jqXHR,textStatus,errorThrown);
        }
    });    
}

And used:

getRequest(url,onSuccess,onFail); 

as @Fabricator pointed out

+3
source

All Articles