I use spring 4.2.0and nifi 0.6.0when I use RestTemplate to call restful api for disabled nifi controllers
public RevisionDTO getRevision() {
Entity revision = restTemplate.getForObject("http://localhost:8083/nifi-api//controller/revision", Entity.class);
return revision.getRevision();
}
protected Map<String, Object> getRevisionUrl(RevisionDTO revision) {
Map<String, Object> urlVar = new HashMap<String, Object>();
urlVar.put("version", revision.getVersion());
urlVar.put("clientId", revision.getClientId());
return urlVar;
}
private void disable(ControllerServiceEntity cs) {
Map<String, Object> urlVar = getRevisionUrl(getRevision());
urlVar.put("state", STATE_DISABLED);
restTemplate.put("http://localhost:8083/nifi-api/controller/controller-services/node/" + cs.getControllerService().getId(), null, urlVar);
}
I got the following error log:
org.springframework.web.client.HttpClientErrorException: 409 Conflict
at org.springframework.web.client.DefaultResponseErrorHandler.handleError(DefaultResponseErrorHandler.java:91)
at org.springframework.web.client.RestTemplate.handleResponse(RestTemplate.java:636)
at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:592)
at org.springframework.web.client.RestTemplate.execute(RestTemplate.java:560)
nifi log
2016-04-11 16:32:53,982 DEBUG [NiFi Web Server-90 - /nifi-api/controller/controller-services/node/5d99ca33-78f6-465e-9ab1-8c7cb5650025] o.a.n.w.StandardOptimisticLockingManager Revision check failed because current revision is [23, 5d4fe4d3-2f32-4a75-899a-458e8e62efce] but supplied revision is [null, 15976fcf-e01b-483c-994b-df812293d7ad]
......
2016-04-11 16:32:53,990 DEBUG [NiFi Web Server-90 - /nifi-api/controller/controller-services/node/5d99ca33-78f6-465e-9ab1-8c7cb5650025] c.s.j.spi.container.ContainerResponse Mapped exception to response: 409 (Conflict)
org.apache.nifi.web.InvalidRevisionException: This NiFi instance has been updated by 'anonymous'. Please refresh to synchronize the view.
at org.apache.nifi.web.StandardOptimisticLockingManager.checkRevision(StandardOptimisticLockingManager.java:62) ~[nifi-web-optimistic-locking-0.6.0.jar:0.6.0]
at org.apache.nifi.web.StandardOptimisticLockingManager.configureFlow(StandardOptimisticLockingManager.java:80) ~[nifi-web-optimistic-locking-0.6.0.jar:0.6.0]
at org.apache.nifi.web.StandardNiFiServiceFacade.updateControllerService(StandardNiFiServiceFacade.java:1714) ~[classes/:0.6.0]
at org.apache.nifi.web.StandardNiFiServiceFacade$$FastClassBySpringCGLIB$$358780e0.invoke() ~[classes/:0.6.0]
browser disabled api screenshot
Is there any way to fix the error?
@Matt Gilman I changed the function in disabletwo ways:
private void disable(ControllerServiceEntity cs) {
ControllerServiceEntity csu = new ControllerServiceEntity();
csu.setRevision(getRevision());
csu.setControllerService(cs.getControllerService());
csu.getControllerService().setState(STATE_DISABLED);
HttpHeaders requestHeaders = new HttpHeaders();
requestHeaders.setContentType(MediaType.APPLICATION_JSON);
HttpEntity<String> requestEntity = new HttpEntity<String>(JSONUtils.obj2json(csu), requestHeaders);
restTemplate.put(url() + cs.getControllerService().getId(), requestEntity);
}
but i got the same error in nifi:
java.lang.IllegalStateException: DBCPConnectionPool[id=fecc88a8-379d-4fb3-b880-28c5f5caef23] cannot be updated because it is not disabled
at org.apache.nifi.controller.service.StandardControllerServiceNode.verifyCanUpdate(StandardControllerServiceNode.java:217) ~[nifi-framework-core-0.6.0.jar:0.6.0]
at org.apache.nifi.web.dao.impl.StandardControllerServiceDAO.verifyUpdate(StandardControllerServiceDAO.java:225) ~[classes/:na]
at org.apache.nifi.web.dao.impl.StandardControllerServiceDAO.updateControllerService(StandardControllerServiceDAO.java:101) ~[classes/:na]
resolved
i compare the request to turn off the browser and run the api doc again, found to disable the controller service should do the following:
- link to stop service
- disable management service link
- set service manager service status
now my new shutdown function
private void disable(ControllerServiceEntity cs) {
HttpHeaders requestHeaders = new HttpHeaders();
requestHeaders.setContentType(MediaType.APPLICATION_FORM_URLENCODED);
MultiValueMap<String, String> urlVar = getRevisionUrl(getRevision());
urlVar.add("state", STATE_STOPPED);
HttpEntity<MultiValueMap<String, String>> requestEntity = new HttpEntity<MultiValueMap<String, String>>(urlVar, requestHeaders);
restTemplate.put(url() + cs.getControllerService().getId() + "/references", requestEntity);
urlVar = getRevisionUrl(getRevision());
requestEntity = new HttpEntity<MultiValueMap<String, String>>(urlVar, requestHeaders);
urlVar.add("state", STATE_DISABLED);
restTemplate.put(url() + cs.getControllerService().getId() + "/references", requestEntity);
urlVar = getRevisionUrl(getRevision());
requestEntity = new HttpEntity<MultiValueMap<String, String>>(urlVar, requestHeaders);
urlVar.add("state", STATE_DISABLED);
restTemplate.put(url() + cs.getControllerService().getId(), requestEntity);
}