How many variables are too many for the class?

Question

I want to see if anyone has a better design for the class (class, like in OOP ) I write. We have a script that puts public folder statistics in a CSV file . I read this and put it in the Share class.

My boss wants to know information like:

• Total number of files
• Total file size
• Number of Office Files
• Office File Size
• Number of Exe Files
• Exe File Size
• etc.

I have a class with variables like $ numOfficeFiles, $ sizeOfficeFiles, etc. with tons of get / set methods. Isn't there a better way to do this? What is the general rule if you have a class with many variables / properties?

I think of it as an agnostic language issue, but if that matters, I use PHP.

Answer 1

, 5 6 , , antsy.

, , Outlaw Programmer. , -.

: , , setter getter, DATA, - - .

, (), , , ( OO, ).

: , , ; , .

GUI , , ; - ( ).

Answer 2

:

files = {
   'total':  { count: 200, size: 3492834 },
   'office': { count: 25, size: 2344 },
   'exe':    { count: 30, size: 342344 },
   ...
}

Answer 3

" "

, , .

.

100-, , .

get/set, "".

EDIT:

, Count Size. , . FileInfo count class, frist FileInfo.

, . "", "Exe"., File Info. FileInfo.

, .

Answer 4

, " , ".

, , .

, , .

Answer 5

"max variables" , . X , , . , , - "", . .

Answer 6

, . # . , :

public class FileStats
{
    public FileStats(String extension)
    {
        // logic to discover files goes here
    }

    public int getSize() { }
    public int getNumFiles() { }
}

, , :

public class Statistics
{
    private static final String[] TYPES = { "exe", "doc", "png" };
    private Collection<FileStats> stats = new HashSet<FileStats>();

    public static void collectStats()
    {            
        stats.clear();
        for(String type : TYPES)
            stats.add(new FileStats(type));
    }
}

API, getter:

public int getNumFiles(String type)
{
    return stats.get(type).getNumFiles();
}

Answer 7

. OO coupling cohesion. , , /, .

Answer 8

, :

, " ".

Answer 9

, , , csv (?). csv.

Answer 10

.

. get/set.

- :

class Test()
{
    private $DATA = array();

    function set($what,$data) {
       $DATA[$what] = $data;
    }

    function get($what) {
        return $this->DATA[$what];
    }
}

Answer 11

, " " " ", . "" .

In this case, it seems that you can start grouping things together, for example, you repeat the actions of number and size many times. Why not create a superclass inherited by other classes, for example:

class NameOfSuperClass {
    public $type;
    function __construct($type) {
        $this->type = $type;
        $this->getNumber();
        $this->getSize();
    }
    public function getNumber() {
        // do something with the type and the number
    }
    public function getSize() {
        // do something with the type and the size
    }
}

Class OfficeFiles extends NameOfSuperClass {
    function __construct() {
        $this->_super("office");
    }
}

I'm not sure if this is correct in PHP, but you understand. Things will start to look a lot cleaner and better managed.