How can I split and crop a string into pieces on the same line?

Question

I want to break this line:

string line = "First Name ; string ; firstName"; 

into the array of their cropped versions:

 "First Name" "string" "firstName" 

How can I do this all on one line? The following is the error "cannot convert void type":

 List<string> parts = line.Split(';').ToList().ForEach(p => p.Trim()); 

Answer 1

Try

 List<string> parts = line.Split(';').Select(p => p.Trim()).ToList(); 

FYI, the Foreach method takes an action (takes T and returns void) for the parameter, and your lambda returns the string as string.Trim returns the string

The Foreach extension method is designed to change the state of objects in a collection. Since the string is immutable, this will have no effect

Hope this helps; o)

Cedric

Answer 2

The ForEach method does not return anything, so you cannot assign it to a variable.

Use the Select extension method instead:

 List<string> parts = line.Split(';').Select(p => p.Trim()).ToList(); 

Answer 3

Since p.Trim () returns a new line.

You need to use:

 List<string> parts = line.Split(';').Select(p => p.Trim()).ToList(); 

Answer 4

Alternatively try the following:

 string[] parts = Regex.Split(line, "\\s*;\\s*"); 

Answer 5

try using regex:

 List<string> parts = System.Text.RegularExpressions.Regex.Split(line, @"\s*;\s*").ToList(); 

Answer 6

Here's the extension method ...

  public static string[] SplitAndTrim(this string text, char separator) { if (string.IsNullOrWhiteSpace(text)) { return null; } return text.Split(separator).Select(t => t.Trim()).ToArray(); } 

Answer 7

Use regex

 string a="bob, jon,man; francis;luke; lee bob"; String pattern = @"[,;\s]"; String[] elements = Regex.Split(a, pattern).Where(item=>!String.IsNullOrEmpty(item)).Select(item=>item.Trim()).ToArray();; foreach (string item in elements){ Console.WriteLine(item.Trim()); 

Result:

bean

John

person

Francis

Luke

lee

bean

Explain pattern [,; \ s]: match one or one of ;;; or whitespace