Why does matlabcontrol interrupt a call to a thread when creating a proxy?

Question

I made my control of Matlab intermittent and found that it was interrupted all the time the first time it started.

This is because GetProxyRequestCallback has code interrupt inside:

 private static class GetProxyRequestCallback implements RequestCallback { private final Thread _requestingThread; private volatile MatlabProxy _proxy; public GetProxyRequestCallback() { _requestingThread = Thread.currentThread(); } @Override public void proxyCreated(MatlabProxy proxy) { _proxy = proxy; _requestingThread.interrupt(); } public MatlabProxy getProxy() { return _proxy; } } 

Is there any reason to interrupt the call to the thread, or is it just a mistake?

Answer 1

The RemoteMatlabProxyFactory.getProxy() method creates an instance of GetProxyRequestCallback and then sleeps, waiting for the proxyCreated(...) method to be proxyCreated(...) . Therefore, if proxyCreated () did not interrupt the thread that originally created the request, this thread will wait until the timeout is reached.

In my opinion, this is a flaw in the matlabcontrol library: Thread.interrupt () should not be abused for this purpose, because the interrupted thread can have different reasons and should not be used for anything other than signaling that the thread should stop.

This should be fixed in the matlabcontrol library, waiting instead of mutex.

For example:

 class RemoteMatlabProxyFactory implements ProxyFactory { // [...] @Override public MatlabProxy getProxy() throws MatlabConnectionException { GetProxyRequestCallback callback = new GetProxyRequestCallback(); Request request = this.requestProxy(callback); return callback.getProxy(_options.getProxyTimeout()); } // [...] } private static class GetProxyRequestCallback implements RequestCallback { private final Object _lock = new Object(); private MatlabProxy _proxy; @Override public void proxyCreated(MatlabProxy proxy) { _proxy = proxy; _requestingThread.interrupt(); } public MatlabProxy getProxy(long timeout) throws MatlabConnectionException { synchronized (_lock) { if (_proxy != null) { return _proxy; } try { _lock.wait(timeout); } catch (InterruptedException e) { Thread.currentThread().interrupt(); throw new MatlabConnectionException("Thread was interrupted while waiting for MATLAB proxy", e); } if (_proxy == null) { throw new MatlabConnectionException("MATLAB proxy could not be created in " + timeout + " milliseconds"); } return _proxy; } } }