Swiftlint warning: for Where Violation: where clauses are preferable to one if if inside a for. (For_where)

Question

I use swift to develop my application and use a fast lint. But I get a warning regarding the following code:

for settingsKeys in searchResults { if settingsKeys.key == settingsObject.key { settingsKeys.value = settingsObject.value try context.save() } } 

Screenshot attached:

Answer 1

The syntax preferred by your swiftlint configuration is as follows:

 for settingsKeys in searchResults where settingsKeys.key == settingsObject.key { settingsKeys.value = settingsObject.value try context.save() } 

What looks like

 for settingsKeys in (searchResults.filter { $0.key == settingsObject.key }) { settingsKeys.value = settingsObject.value try context.save() } 

If you know that there is only one result with the same key , you can directly use

 if let settingsKeys = (searchResults.first { $0.key == settingsObject.key }) { settingsKeys.value = settingsObject.value try context.save() } 

Answer 2

It looks like he expects where be part of for ...

 for settingsKeys in searchResults where settingsKeys.key == settingsObject.key { settingsKeys.value = settingsObject.value try context.save() }