Suspicious warning from Resharper - should I change my code?

Question

With the following code:

if (lombardiTrophy.Substring(1, 1).Equals('~')) 

... I get: "Suspicious comparison: the solution does not have a type inherited from" string "and" char "

Is there a better way to do this that won't force Resharper to pick up its hacks?

Answer 1

You should heed the ReSharper warning. The substring returns a string, and the single quote notation is char, so you are comparing two different types. You should compare char with char, which you can do as follows:

 if (lombardiTrophy[1].Equals('~')) 

Of course, you want to make sure your string is at least two characters long.

Answer 2

Try the following:

  if (lombardiTrophy.Substring(1, 1).Contains("~")) 

Pay attention to double quotes for string comparison.