Actions in onActivityResult and "Error Unable to complete this action after onSaveInstanceState"

Question

An application in which a user can log in. I have the following situation: if the user is logged in, perform the else action by starting the login operation for the result, and if the result is Activity.RESULT_OK, it will execute the action.

My problem is that the action to execute is to show DialogFragment but call

DialogFragment newFragment = MyDialogFragment.newInstance(mStackLevel); newFragment.show(ft, "dialog") 

the onActivityResult callback throws an exception:

 Caused by: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState 

So how can I solve this? I think I raise the flag there and show the dialog in onResume, but I see this solution a little dirty

Edit: added more code (Im following this example to show DialogFragment

When an action is requested by the user:

 ... if (!user.isLogged()){ startActivityForResult(new Intent(cnt, Login.class), REQUEST_LOGIN_FOR_COMMENT); } 

In the same fragment

 @Override public void onActivityResult(int requestCode, int resultCode, Intent data) { super.onActivityResult(requestCode, resultCode, data); if (requestCode == REQUEST_LOGIN_FOR_COMMENT && resultCode == Activity.RESULT_OK) { FragmentTransaction ft = getFragmentManager().beginTransaction(); DialogFragment newFragment = MyDialogFragment.newInstance(); newFragment.show(ft, "dialog") } } 

And if the user logs in activity calls,

 setResult(Activity.RESULT_OK); finish(); 

Answer 1

The best I came up with is not to use .show (), but rather to do it.

 CheckinSuccessDialog dialog = new CheckinSuccessDialog(); //dialog.show(getSupportFragmentManager(), null); FragmentTransaction ft = getSupportFragmentManager().beginTransaction(); ft.add(dialog, null); ft.commitAllowingStateLoss(); 

Answer 2

Here is a workaround that works great for me.

 private void alert(final String message) { Handler handler = new Handler(Looper.getMainLooper()); handler.post(new Runnable() { public void run() { AlertDialogFragment alertDialogFragment = AlertDialogFragment.newInstance(message); alertDialogFragment.show(getFragmentManager(), ALERT_DIALOG_FRAGMENT); } }); } 

Answer 3

If using DialogFragment, the only thing that worked for me was to drop the fragment using dissmissAllowingStateLoss ()

Answer 4

I just check if the action is destroyed.

 if (!getActivity().isFinishing()) { DialogFragment fragment = MyFragment.newInstance(); fragment.show(getActivity().getSupportFragmentManager(), MyFragment.TAG); } 

Answer 5

Override the show(Fragment manager, String tag) function show(Fragment manager, String tag) , allowing it to lose state and change mDismissed = false; mShownByMe = true; from the origibal function by reflection:

 public class DialogParent extends DialogFragment { @Override public void show(FragmentManager manager, String tag) { try { Field mDismissed = DialogFragment.class.getDeclaredField("mDismissed"); Field mShownByMe = DialogFragment.class.getDeclaredField("mShownByMe"); mDismissed.setAccessible(true); mShownByMe.setAccessible(true); mDismissed.setBoolean(this, false); mShownByMe.setBoolean(this, true); } catch (NoSuchFieldException e) { e.printStackTrace(); } catch (IllegalAccessException e) { e.printStackTrace(); } FragmentTransaction ft = manager.beginTransaction(); ft.add(this, tag); ft.commitAllowingStateLoss(); } } 

Answer 6

Real work.

 CheckinSuccessDialog dialog = new CheckinSuccessDialog(); //dialog.show(getSupportFragmentManager(), null); FragmentTransaction ft = getSupportFragmentManager().beginTransaction(); ft.add(dialog, null); ft.commitAllowingStateLoss(); 

But still bad, because the error "Activity was destroyed" was received

 ava.lang.IllegalStateException: Activity has been destroyed fragmentTransaction.commitAllowingStateLoss(); 

So my solution adds check if (!isFinishing()&&!isDestroyed())

 CheckinSuccessDialog fragment = CheckinSuccessDialog.newInstance(); if (fragment instanceof DialogFragment) { DialogFragment dialog = (DialogFragment) fragment; if (!dialog.isAdded()) { fragmentTransaction.add(dialog, CheckinSuccessDialog.class.getName()); if (!isFinishing()&&!isDestroyed()) { fragmentTransaction.commitAllowingStateLoss(); } } 

upon dismissal:

 FragmentTransaction fragmentTransaction = getSupportFragmentManager().beginTransaction(); Fragment fragment = getSupportFragmentManager().findFragmentByTag(CheckinSuccessDialog.class.getName()); if (fragment != null && fragment instanceof DialogFragment) { DialogFragment dialog = (DialogFragment) fragment; dialog.dismiss(); if (!isFinishing()&&!isDestroyed()) { fragmentTransaction.commitAllowingStateLoss(); } } 

Answer 7

This exception is thrown whenever a FragmentTrasaction committed after the FragmentManager has retained its state. An easy and clean way is to check if the FragmentManager has already saved state before showing DialogFragment .

 if(!getSupportFragmentManager.isStateSaved()) { MyDialogFragment dialogFragment = new MyDialogFragment() dialogFragment.show(getSupportFragmentManager, TAG); }